Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move TableLoader traits to read_...-methods #2482

Merged
merged 16 commits into from
Jan 4, 2024
Merged

Move TableLoader traits to read_...-methods #2482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
78f53c7
Initial commit
Hckjs Oct 26, 2023
866f69b
Fix call order for read_telescope_events
ccossou Oct 27, 2023
31be16f
Fix all unit test but the chunks one.
ccossou Oct 27, 2023
4e1f21c
Fix chunked test
Hckjs Oct 27, 2023
ddcf4c0
Adding args check function and adapting tests
Hckjs Nov 15, 2023
70b83b3
Merge branch 'main' into move_table_loader_traits
Hckjs Nov 15, 2023
8c09e16
Undo debugging adaption
Hckjs Nov 15, 2023
7d3abd7
Add TableLoader tutorial from dpps meeting
Hckjs Nov 25, 2023
2974a1b
Merge branch 'main' into move_table_loader_traits
Hckjs Dec 12, 2023
cec3714
Update example Tutorial
Hckjs Dec 13, 2023
a718cfc
Delete docs/sg_execution_times.rst
Hckjs Dec 13, 2023
a81fb43
Fixing some Codacy quality checks
Hckjs Dec 13, 2023
d617821
Adding changelog
Hckjs Dec 13, 2023
8b9aa39
Use some more html repr in the tutorials
Hckjs Dec 15, 2023
f46e8a6
Change default values of TableLoader
Hckjs Dec 19, 2023
592278b
Fix changelog
Hckjs Dec 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 10 additions & 8 deletions ctapipe/instrument/tests/test_trigger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,6 @@ def test_software_trigger_simtel(allowed_tels):
with EventSource(
path, focal_length_choice="EQUIVALENT", allowed_tels=allowed_tels
) as source:

trigger = SoftwareTrigger(
subarray=source.subarray,
min_telescopes=2,
Expand Down Expand Up @@ -152,7 +151,6 @@ def test_software_trigger_simtel_single_lsts():
with EventSource(
path, focal_length_choice="EQUIVALENT", allowed_tels=allowed_tels
) as source:

trigger = SoftwareTrigger(
subarray=source.subarray,
min_telescopes=2,
Expand Down Expand Up @@ -218,18 +216,22 @@ def test_software_trigger_simtel_process(tmp_path):

with TableLoader(
output_path,
load_simulated=True,
load_dl1_parameters=True,
focal_length_choice="EQUIVALENT",
) as loader:
events_trigger = loader.read_telescope_events("LST_LST_LSTCam")
events_trigger = loader.read_telescope_events(
"LST_LST_LSTCam",
dl2=False,
true_parameters=False,
)

with TableLoader(
output_path_no_software_trigger,
load_simulated=True,
load_dl1_parameters=True,
focal_length_choice="EQUIVALENT",
) as loader:
events_no_trigger = loader.read_telescope_events("LST_LST_LSTCam")
events_no_trigger = loader.read_telescope_events(
"LST_LST_LSTCam",
dl2=False,
true_parameters=False,
)

assert len(events_no_trigger) > len(events_trigger)