Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test on python 3.12 #2486

Merged
merged 3 commits into from Feb 21, 2024
Merged

Test on python 3.12 #2486

merged 3 commits into from Feb 21, 2024

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Jan 8, 2024

No description provided.

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c4853a7) 92.53% compared to head (e1c7713) 92.52%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2486      +/-   ##
==========================================
- Coverage   92.53%   92.52%   -0.01%     
==========================================
  Files         235      235              
  Lines       20024    20024              
==========================================
- Hits        18529    18528       -1     
- Misses       1495     1496       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxnoe
Copy link
Member Author

maxnoe commented Jan 8, 2024

wohoo 🎆

kosack
kosack previously approved these changes Jan 16, 2024
@maxnoe maxnoe marked this pull request as draft January 16, 2024 10:41
@maxnoe maxnoe changed the title Try running CI with numba 0.59rc1 including python 3.12 Test on python 3.12 Feb 7, 2024
@maxnoe maxnoe marked this pull request as ready for review February 7, 2024 09:52
@maxnoe
Copy link
Member Author

maxnoe commented Feb 7, 2024

Codecov project fails due to the changed python version for the coverage report now testing different lines in the compat code which happen to be slightly less lines. So I'd say this is ready to go.

@@ -43,19 +43,23 @@ jobs:

- os: ubuntu-latest
python-version: "3.10"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why phyton 3.10 only uses pip while 3.9, 3.11, and 3.12 also tries mamba?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No particular reason, we at some point in the past decided not to test on the full product matrix of [python versions] x [pip, mamba] but to only test some combinations that cover all python versions and both installation methods.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To limit the number of parallel builds that run in the CI

@maxnoe maxnoe requested a review from Tobychev February 7, 2024 13:18
@maxnoe
Copy link
Member Author

maxnoe commented Feb 20, 2024

@kosack this would be ready

@maxnoe maxnoe merged commit daf12f0 into main Feb 21, 2024
14 of 15 checks passed
@maxnoe maxnoe deleted the python312 branch February 21, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants