Improve logging colorization, fixes #2504 #2505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
force-pushed
the
fix_unknown_logging
branch
2 times, most recently
from
31cf13a
to
fa2627f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2505 +/- ##
=======================================
Coverage 92.52% 92.53%
=======================================
Files 234 235 +1
Lines 20005 20024 +19
=======================================
+ Hits 18510 18529 +19
Misses 1495 1495 ☔ View full report in Codecov by Sentry. |
Tobychev
previously approved these changes
Jan 26, 2024
kosack
previously approved these changes
Jan 26, 2024
maxnoe
force-pushed
the
fix_unknown_logging
branch
from
fa2627f
to
e15a936
Compare
kosack
previously approved these changes
Jan 26, 2024
maxnoe
force-pushed
the
fix_unknown_logging
branch
from
e15a936
to
105a55c
Compare
kosack
previously approved these changes
Jan 26, 2024
kosack
reviewed
Jan 26, 2024
maxnoe
force-pushed
the
fix_unknown_logging
branch
from
105a55c
to
c81babd
Compare
Tobychev
approved these changes
Jan 26, 2024
kosack
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.