Fix possible out of bounds error in FlashCamExtractor #2544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschwefer
previously approved these changes
Apr 24, 2024
|
macos test is now failing because macos-latest was updated to be macos 14 on M1 for which no pytables wheel exist, let's merge: #2534 |
maxnoe
force-pushed
the
fix_flashcam_extractor
branch
from
aa6db8e
to
3aa397f
Compare
maxnoe
force-pushed
the
fix_flashcam_extractor
branch
from
3aa397f
to
03bd7f3
Compare
This comment has been minimized.
This comment has been minimized.
maxnoe
commented
Apr 24, 2024
kosack
approved these changes
Apr 25, 2024
gschwefer
approved these changes
Apr 25, 2024
maxnoe
force-pushed
the
fix_flashcam_extractor
branch
from
bb99355
to
dba9d7d
Compare
Analysis Details0 Issues
Coverage and Duplications
Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code had a possible out of bounds array access in case of the peak not being fully contained in the waveform.
Should fix a segfault reported by @gschwefer