Compute deconvolution parameters in FlashCamExtractor only as needed #2545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
force-pushed
the
better_conv_params
branch
from
e3d95fd
to
e1acb2b
Compare
kosack
previously approved these changes
Apr 25, 2024
clara-escanuela
previously approved these changes
Apr 25, 2024
|
Looks like you missed a spot in > pole_zeros, gains, shifts, pz2ds = self.deconvolution_pars[tel_id]
E AttributeError: 'FlashCamExtractor' object has no attribute 'deconvolution_pars'. Did you mean: '_deconvolution_pars'? |
maxnoe
force-pushed
the
better_conv_params
branch
from
e1acb2b
to
c6f654a
Compare
|
Thanks, fixed. Also rebased to get the CI fix in. |
maxnoe
force-pushed
the
better_conv_params
branch
2 times, most recently
from
65749a3
to
31e8b81
Compare
maxnoe
force-pushed
the
better_conv_params
branch
from
31e8b81
to
e6d7c47
Compare
|
Merging, only a small fix after the approving reviews of @kosack and @clara-escanuela |
Analysis Details0 Issues
Coverage and Duplications
Project ID: cta-observatory_ctapipe_AY52EYhuvuGcMFidNyUs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.