Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit to h_max in HillasReconstructor #797

Merged
merged 2 commits into from Oct 10, 2018
Merged

Add unit to h_max in HillasReconstructor #797

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
374b4aa
Add unit to h_max
Oct 10, 2018
eb1c084
Fix test
Oct 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion ctapipe/reco/HillasReconstructor.py
View file
Open in desktop
Expand Up @@ -313,7 +313,7 @@ def estimate_h_max(self):
positions = [plane.pos for plane in self.hillas_planes.values()]

# not sure if its better to return the length of the vector of the z component
return np.linalg.norm(line_line_intersection_3d(uvw_vectors, positions))
return np.linalg.norm(line_line_intersection_3d(uvw_vectors, positions)) * u.m


class HillasPlane:
Expand Down
2 changes: 1 addition & 1 deletion ctapipe/reco/tests/test_HillasReconstructor.py
View file
Open in desktop
Expand Up @@ -76,7 +76,7 @@ def test_h_max_results():


# the results should be close to the direction straight up
np.testing.assert_allclose(h_max_reco, 0, atol=1e-8)
np.testing.assert_allclose(h_max_reco.value, 0, atol=1e-8)
# np.testing.assert_allclose(fitted_core_position.value, [0, 0], atol=1e-3)


Expand Down