adding tels pointing #123
Closed
adding tels pointing #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HealthyPear
requested changes
Mar 30, 2021
| # if all telescopes are pointing in parallel to run_array_direction, no need to pass the tels | ||
| # pointing to predict | ||
| if all(x.alt == event.mcheader.run_array_direction[1] | ||
| and x.az == event.mcheader.run_array_direction[0] for x in tels_pointing.values()): |
There was a problem hiding this comment.
I think you mean point_altitude_dict.values()
There was a problem hiding this comment.
and this is what is killing the tests, here an extract
Traceback (most recent call last):
File "/home/runner/work/protopipe/protopipe/protopipe/scripts/data_training.py", line 573, in <module>
main()
File "/home/runner/work/protopipe/protopipe/protopipe/scripts/data_training.py", line 235, in main
for (
File "/home/runner/work/protopipe/protopipe/protopipe/pipeline/event_preparer.py", line 929, in prepare_event
and x.az == event.mcheader.run_array_direction[0] for x in tels_pointing.values()):
UnboundLocalError: local variable 'tels_pointing' referenced before assignment
|
This PR makes me realize that we should have also a divergent test suite! Site wouldn't be important since now with the new integration tests we already test parallel pointing on both sites Should we then close #38? |
HealthyPear
requested changes
May 12, 2021
| # if all telescopes are pointing in parallel to run_array_direction, no need to pass the tels | ||
| # pointing to predict | ||
| if all(x.alt == event.mcheader.run_array_direction[1] | ||
| and x.az == event.mcheader.run_array_direction[0] for x in tels_pointing.values()): |
There was a problem hiding this comment.
and this is what is killing the tests, here an extract
Traceback (most recent call last):
File "/home/runner/work/protopipe/protopipe/protopipe/scripts/data_training.py", line 573, in <module>
main()
File "/home/runner/work/protopipe/protopipe/protopipe/scripts/data_training.py", line 235, in main
for (
File "/home/runner/work/protopipe/protopipe/protopipe/pipeline/event_preparer.py", line 929, in prepare_event
and x.az == event.mcheader.run_array_direction[0] for x in tels_pointing.values()):
UnboundLocalError: local variable 'tels_pointing' referenced before assignment
HealthyPear
added
divergent pointing
enhancement
HealthyPear
added this to In progress
in Pipeline features and enhancements
via automation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
superseeds #38