Add configuration option to choose which cleaning to use to get training data #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HealthyPear
added this to In progress
in Pipeline features and enhancements
via automation
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
- Coverage 60.36% 60.20% -0.17%
==========================================
Files 23 23
Lines 2122 2141 +19
==========================================
+ Hits 1281 1289 +8
- Misses 841 852 +11
Continue to review full report at Codecov.
|
kosack
approved these changes
May 10, 2021
Pipeline features and enhancements
automation
moved this from In progress
to Reviewer approved
May 10, 2021
Pipeline features and enhancements
automation
moved this from Reviewer approved
to Done
May 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous situation was one in which both cleanings were computed and recorded
biggest(meaning biggest cluster)extended(meaning all clusters)but the one used for image quality and shower geometry was always the one using the biggest cluster.
In accordance with #117, now it will be possible to choose between the 2 from
analysis.yaml(underImageSelection/source), and the default option is set to be "extended".