Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for calibscale #140

Conversation

HealthyPear
Copy link
Member

This PR adds the choice of calibscale from the analysis configuration file setting 1.0 (i.e. no calibscale) as default and scaling the extracted image before cleaning.

@HealthyPear HealthyPear added enhancement New feature or request DL1a labels May 17, 2021
@HealthyPear HealthyPear added this to In progress in Pipeline features and enhancements via automation May 17, 2021
@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #140 (a6625da) into master (57d344a) will decrease coverage by 0.40%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   65.59%   65.19%   -0.41%     
==========================================
  Files          23       23              
  Lines        2142     2146       +4     
==========================================
- Hits         1405     1399       -6     
- Misses        737      747      +10     
Impacted Files Coverage Δ
protopipe/pipeline/event_preparer.py 64.13% <60.00%> (-1.10%) ⬇️
protopipe/perf/temp.py 87.50% <0.00%> (-12.50%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57d344a...a6625da. Read the comment docs.

@HealthyPear HealthyPear requested a review from kosack May 17, 2021 14:11
Pipeline features and enhancements automation moved this from In progress to Reviewer approved May 17, 2021
@HealthyPear HealthyPear merged commit fd7b693 into cta-observatory:master May 17, 2021
Pipeline features and enhancements automation moved this from Reviewer approved to Done May 17, 2021
@HealthyPear HealthyPear deleted the feature-add_support_for_calibscale branch May 17, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DL1a enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

2 participants