Comparison with CTA-MARS: Calibration

[HealthyPear]

This issue is part of a project described in issue #24

The following is a "real-time" list of points that are found to be differences between the pipelines using the comparison.
Not all features are critical to recover the missing performance, but all should be implemented (as more similar as possible) in order to allow their optional use when comparing different algorithms.

---

• Remove images that do not survive the preliminary image cleaning in-between the 2 passes of image extraction

Issues

• Add image extraction status #161

---

• Set gain selection to use threshold at R0 data-level ( closed PR Change gain selection #35 )

Description:

• protopipe performs calibration entirely through ctapipe,
• in ctapipe 0.7.0 the default gain choice comes from CHEC-camera development in which there is only one channel
  • the code was set up to choose the first channel, which is the high gain one
  • as correctly reported here by @moralejo, old plots (which will be updated from the above-mentioned PR) refer to such channel,
• also, thanks to this project, we found that in ctapipe such gain choice was done using R1-level data instead of R0 (see GainSelection should be applied to R0 waveform, not R1 ctapipe#1166)

---

• missing 2nd-pass in pulse integration

Pull-Requests

• ctapipe at 2-Pass waveform integration à-la-CTA/MARS ctapipe#1215
• protopipe Double-pass image extractor #48

Description:
explained in detail here.
As with many other features, it will be developed in parallel in the developoment version of ctapipe (and imported from there with the new release) and in protopipe (based on ctapipe 0.7 conda version)

---

• Add support and apply calibscale

It should be done in ctapipe but for the moment done also here in PR #140 .

Description:
as explained here/Conversion to "photoelectrons",

the factor to transform the integrated charges (in ADC counts) into number of photoelectrons is the pixel-wise one calculated by simtelarray (0.92*LasCalData->calib[][][]).

We thus need to check if in ctapipe this value is taken into account.