Change gain selection #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request is part of issue #31 and, as such, it has a higher priority.
Gain selection is now done on the basis of a threshold set on R0 data of 4000 ADC counts.
The code necessary to do this had to be hardcoded.
With the next release of ctapipe it will be removed and imported directly from the
EventSourceclass.As a side result of the comparison at this stage, I also added the exporting of the simulated energy in the
images.h5file. This quantity is needed for the re-weighting of the events according to requirement B-TEL-1010 "Intensity Resolution".