New plots for calibration benchmarking #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB. |
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
======================================
Coverage 0.43% 0.43%
======================================
Files 20 20
Lines 2084 2084
======================================
Hits 9 9
Misses 2075 2075 Continue to review full report at Codecov.
|
kosack
reviewed
Feb 19, 2020
| @@ -32,11 +32,11 @@ | |||
| "\n", | |||
There was a problem hiding this comment.
What is the purpose of this function? Wouldn't it just work to pass max_events to it, and if it's none, it will work fine (no need for the if-statement, I think)
Reply via ReviewNB
HealthyPear
added this to In progress
in Pipeline features and enhancements
via automation
Pipeline features and enhancements
automation
moved this from In progress
to Reviewer approved
Mar 31, 2020
kosack
approved these changes
Mar 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the framework of #31 , it will be useful to compare quantities before the process of image extraction.
The new plots show pedestals and dc_to_phe conversion factor as read by
ctapipe.io.event_sourcefrom the simtel file used in the comparison.