Implement read functions for simple types #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dneise
reviewed
Dec 2, 2018
|
|
||
|
|
||
| def read_from_without_position_change(fmt, f): | ||
| def read_from_without_position_change(f, fmt): |
There was a problem hiding this comment.
This function seems to be implemented but never used. Was it a test of some kind and should be removed, or do you plan to use it later somewhere?
There was a problem hiding this comment.
This was used in the old version all over the place but is probably not needed anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A little syntactic sugar, removes the need to remember struct formats and adding the commas if one only reads one number.