Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize edisp to integral of 1, not sum of 1 #250

Merged
merged 15 commits into from
Aug 23, 2023

Address review comments

1164644
Select commit
Failed to load commit list.
Merged

Normalize edisp to integral of 1, not sum of 1 #250

Address review comments
1164644
Select commit
Failed to load commit list.
Codecov / codecov/project succeeded Aug 22, 2023 in 1s

94.78% (+0.05%) compared to 19fff68

View this Pull Request on Codecov

94.78% (+0.05%) compared to 19fff68

Details

Codecov Report

Patch coverage: 99.35% and project coverage change: +0.05% 🎉

Comparison is base (19fff68) 94.73% compared to head (1164644) 94.78%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   94.73%   94.78%   +0.05%     
==========================================
  Files          60       60              
  Lines        2981     3050      +69     
==========================================
+ Hits         2824     2891      +67     
- Misses        157      159       +2     
Files Changed Coverage Δ
pyirf/interpolation/__init__.py 100.00% <ø> (ø)
pyirf/interpolation/utils.py 97.61% <88.88%> (-2.39%) ⬇️
pyirf/interpolation/component_estimators.py 99.27% <92.85%> (-0.73%) ⬇️
pyirf/interpolation/base_extrapolators.py 100.00% <100.00%> (ø)
pyirf/interpolation/base_interpolators.py 96.87% <100.00%> (+0.57%) ⬆️
pyirf/interpolation/moment_morph_interpolator.py 100.00% <100.00%> (ø)
pyirf/interpolation/nearest_neighbor_searcher.py 100.00% <100.00%> (ø)
...yirf/interpolation/nearest_simplex_extrapolator.py 100.00% <100.00%> (ø)
pyirf/interpolation/quantile_interpolator.py 98.24% <100.00%> (+0.09%) ⬆️
...irf/interpolation/tests/test_base_extrapolators.py 100.00% <100.00%> (ø)
... and 10 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.