Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize edisp to integral of 1, not sum of 1 #250

Merged
merged 15 commits into from Aug 23, 2023
Merged

Normalize edisp to integral of 1, not sum of 1 #250

merged 15 commits into from Aug 23, 2023

Commits on Aug 2, 2023

  1. Normalize edisp to integral of 1, not sum of 1

    @maxnoe
    maxnoe committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    8275a43 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2023

  1. Start working on fixing interpolation for fixed edisp

    @maxnoe
    maxnoe committed Aug 3, 2023
    Configuration menu
    Copy the full SHA
    a3477c9 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Add normalization arg to PDF interpolator class

    @maxnoe
    maxnoe committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    b9b2081 View commit details
    Browse the repository at this point in the history

  2. Change binned_normal_pdf to have integral 1

    @maxnoe
    maxnoe committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    bb66247 View commit details
    Browse the repository at this point in the history

  3. Start working on fixing interpolation...

    @maxnoe
    maxnoe committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    6d51dc6 View commit details
    Browse the repository at this point in the history

  4. Fix mean / std estimation for psf

    @maxnoe
    maxnoe committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    8fe8b87 View commit details
    Browse the repository at this point in the history

  5. Run black

    @maxnoe
    maxnoe committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    0705afa View commit details
    Browse the repository at this point in the history

  6. Fix some errors in tests

    @maxnoe
    maxnoe committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    3c81ad9 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2023

  1. Adapt interpolation to new normalization of binned pdfs

    @maxnoe
    maxnoe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    ba7c0dd View commit details
    Browse the repository at this point in the history

  2. Fix typo

    @maxnoe
    maxnoe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    1cd2c58 View commit details
    Browse the repository at this point in the history

  3. Assume uniform distribution for pdfs where only a single bin has a va… 

    …lue != 0 in moment morphing
    @maxnoe
    maxnoe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    f4a929c View commit details
    Browse the repository at this point in the history

  4. Merge pull request #251 from cta-observatory/fixed_edisp_interpolation 

    Start working on fixing interpolation for fixed edisp
    @maxnoe
    maxnoe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    2dd65fe View commit details
    Browse the repository at this point in the history

  5. Add changelog entry

    @maxnoe
    maxnoe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    e02405c View commit details
    Browse the repository at this point in the history

  6. Add missing tests/__init__.py

    @maxnoe
    maxnoe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    db105c1 View commit details
    Browse the repository at this point in the history

  7. Address review comments

    @maxnoe
    maxnoe committed Aug 22, 2023
    Configuration menu
    Copy the full SHA
    1164644 View commit details
    Browse the repository at this point in the history