Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Li & Ma significance for n_off = 0 #86

Merged
merged 3 commits into from
Oct 1, 2020
Merged

Fix Li & Ma significance for n_off = 0 #86

merged 3 commits into from
Oct 1, 2020

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Oct 1, 2020

This adds a check to give the correct limit of the li & ma formula for n_off -> 0, also adds test to make sure we get the same values as gammapy

@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #86 into master will increase coverage by 1.62%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
+ Coverage   83.05%   84.68%   +1.62%     
==========================================
  Files          33       34       +1     
  Lines        1021     1038      +17     
==========================================
+ Hits          848      879      +31     
+ Misses        173      159      -14     
Impacted Files Coverage Δ
pyirf/statistics.py 94.44% <100.00%> (+77.77%) ⬆️
pyirf/tests/test_statistics.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f65a41...d141480. Read the comment docs.

@maxnoe maxnoe merged commit f9189c5 into master Oct 1, 2020
@maxnoe maxnoe deleted the fix_lima_n_off branch October 1, 2020 12:57
@maxnoe maxnoe changed the title Fix lima n off = 0 Fix Li & Ma significance for n_off = 0 Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants