Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix brentq returning the lower bound of 0 for flat li ma function #89

Merged
merged 5 commits into from Oct 1, 2020

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Oct 1, 2020

No description provided.

LukasNickel
LukasNickel previously approved these changes Oct 1, 2020
LukasNickel
LukasNickel previously approved these changes Oct 1, 2020
@codecov
Copy link

codecov bot commented Oct 1, 2020

Codecov Report

Merging #89 into master will increase coverage by 1.51%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   85.27%   86.78%   +1.51%     
==========================================
  Files          35       35              
  Lines        1073     1090      +17     
==========================================
+ Hits          915      946      +31     
+ Misses        158      144      -14     
Impacted Files Coverage Δ
pyirf/sensitivity.py 68.42% <85.71%> (+29.95%) ⬆️
pyirf/statistics.py 94.73% <100.00%> (+0.29%) ⬆️
pyirf/tests/test_sensitivity.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84889e0...90079c0. Read the comment docs.

@maxnoe maxnoe changed the title Add missing parenthese Fix brentq returning the lower bound of 0 for flat li ma function Oct 1, 2020
@HealthyPear HealthyPear merged commit 3eb05ea into master Oct 1, 2020
@maxnoe maxnoe deleted the fix_lima branch October 1, 2020 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants