Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix brentq returning the lower bound of 0 for flat li ma function #89

Merged
merged 5 commits into from Oct 1, 2020
Merged

Fix brentq returning the lower bound of 0 for flat li ma function #89

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ca90915
Add missing parenthese
maxnoe Oct 1, 2020
5172bd8
Also n_on case
maxnoe Oct 1, 2020
74b0f34
Do no require at least 1 background event
maxnoe Oct 1, 2020
a516228
Fix brentq returning 0 by giving a non-zero lower bound
maxnoe Oct 1, 2020
90079c0
Add test for sensitivity
maxnoe Oct 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyirf/statistics.py
View file
Open in desktop
Expand Up @@ -46,7 +46,7 @@ def li_ma_significance(n_on, n_off, alpha=0.2):

significance = np.sqrt(ts * 2)

significance[n_on < alpha * n_off] = 0
significance[n_on < (alpha * n_off)] = 0

if scalar:
return significance[0]
Expand Down