Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

SourceLink.Embed.AllSourceFiles creates FullPathEmbeddedFiles but never uses it #334

Closed
mungojam opened this issue May 10, 2018 · 2 comments
Closed

SourceLink.Embed.AllSourceFiles creates FullPathEmbeddedFiles but never uses it #334

mungojam opened this issue May 10, 2018 · 2 comments

Comments

@mungojam
Copy link

I may be just missing an msbuild intricacy, but I just wonder if the CreateProperty in this code is actually meant to be using FullPathEmbeddedFiles instead of EmbeddedFiles. Or maybe FullPathEmbeddedFiles is used in some of the sister packages.

SourceLink/SourceLink.Embed.AllSourceFiles/SourceLink.Embed.AllSourceFiles.targets

Line 13 in 354ead0

<CreateProperty Value="@(EmbeddedFiles)">

@mungojam mungojam changed the title Logic creates FullPathEmbeddedFiles but never uses it SourceLink.Embed.AllSourceFiles creates FullPathEmbeddedFiles but never uses it May 10, 2018
@ctaggart
Copy link
Owner

Yeah, that looks like a bug. It will only affect F# projects. See dotnet/fsharp#4075

@ctaggart
Copy link
Owner

This has been replaced by .NET SDK built in functionality #342.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ctaggart @mungojam