Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Embed property with EmbeddedFiles item group in Microsoft.FSharp.Targets #4075

Closed
tmat opened this issue Dec 8, 2017 · 3 comments
Closed

Replace Embed property with EmbeddedFiles item group in Microsoft.FSharp.Targets #4075

tmat opened this issue Dec 8, 2017 · 3 comments
Milestone
16.0

Comments

@tmat
Copy link
Member

tmat commented Dec 8, 2017 •
edited
Loading

We need to unify on EmbeddedFiles item group accross C#, VB and F#. The former two use EmbeddedFiles item group while F# uses Embed property.

Replace

Embed="$(Embed)"

with

Embed="@(EmbeddedFiles)"
@tmat
Copy link
Member Author

tmat commented Dec 8, 2017

@KevinRansom

@cartermp cartermp added this to the VS 2017 Updates milestone Dec 8, 2017
@dsyme
Copy link
Contributor

dsyme commented Dec 8, 2017

@tmat Is this a breaking change?

@tmat
Copy link
Member Author

tmat commented Dec 8, 2017

@dsyme Yes. You can make it non-breaking if you replace it with Embed="$(Embed);@(EmbeddedFiles)".

@ctaggart ctaggart mentioned this issue Dec 28, 2017
Merged
@ctaggart ctaggart mentioned this issue May 21, 2018
Closed
@cartermp cartermp modified the milestones: VS 2017 Updates, 16.0 Jun 20, 2018
@KevinRansom KevinRansom self-assigned this Aug 9, 2018
KevinRansom added a commit to KevinRansom/fsharp that referenced this issue Aug 9, 2018
@KevinRansom
Fix dotnet#4075
7647d56
KevinRansom added a commit to KevinRansom/fsharp that referenced this issue Aug 9, 2018
@KevinRansom
Fix dotnet#4075
c046a2e
TIHan pushed a commit to TIHan/visualfsharp that referenced this issue Sep 5, 2018
@KevinRansom @TIHan
Fix dotnet#4075 - Replace Embed property with EmbeddedFiles item grou…
6e5e5c8 
…p in Microsoft.FSharp.Targets (dotnet#5487)

* Fix dotnet#4075

* EmbeddedFiles
@cartermp cartermp mentioned this issue Sep 13, 2018
Closed
@tmat tmat mentioned this issue Sep 30, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
16.0
Development

No branches or pull requests
4 participants
@tmat @KevinRansom @cartermp @dsyme