This repository has been archived by the owner on Feb 8, 2022. It is now read-only.
migrate to .NET Core project files #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctaggart
commented
Dec 19, 2017
| open Fake.Core.TargetOperators | ||
| open Fake.DotNet | ||
| open Fake.DotNet.NuGet.NuGet | ||
| open Fake.DotNet.Testing.XUnit2 |
There was a problem hiding this comment.
Lot's more namespaces to import for FAKE 5.
ctaggart
commented
Dec 19, 2017
|
|
||
| let release = ReleaseNotesHelper.LoadReleaseNotes "release_notes.md" | ||
| let isAppVeyorBuild = buildServer = BuildServer.AppVeyor | ||
| let isAppVeyorBuild = match buildServer with AppVeyor -> true | _ -> false |
There was a problem hiding this comment.
The supported build servers are a union which is cool.
ctaggart
commented
Dec 19, 2017
| @@ -24,12 +31,12 @@ let mutable configuration = "Release" | |||
|
|
|||
| MSBuildDefaults <- { MSBuildDefaults with Verbosity = Some MSBuildVerbosity.Minimal } | |||
|
|
|||
| Target "BuildVersion" <| fun _ -> | |||
| Target.Create "BuildVersion" <| fun _ -> | |||
There was a problem hiding this comment.
In FAKE 5, create the targets with Target.Create instead of Target.
ctaggart
commented
Dec 19, 2017
| Target "UnitTest" <| fun _ -> | ||
| CreateDir "bin" | ||
| if not isMono then | ||
| ["Froto.TypeProvider.TestAndDocs.sln"] |
There was a problem hiding this comment.
I couldn't get the TypeProvider tests to build on Travis. Something to do with not finding the proto file passed in.
ctaggart
commented
Dec 19, 2017
| remote: https://api.nuget.org/v3/index.json | ||
| FAKE (5.0.0-beta010) | ||
| xunit.runner.console (2.3.1) |
There was a problem hiding this comment.
paket only used for loading FAKE
ctaggart
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #73
What is left: