This repository has been archived by the owner on Feb 8, 2022. It is now read-only.
fix Enum in message body error #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 8, 2018 11:23
ctaggart
reviewed
Oct 8, 2018
Parser.Test/TestParser.fs
Outdated
|
|
||
| [<Fact>] | ||
| let ``proto3 message with enum type doesn't parse (#93)`` () = | ||
| System.Diagnostics.Debugger.Break() |
There was a problem hiding this comment.
Oops, yeah, removed :-)
|
published 0.6.2 to NuGet Gallery |
|
So the tests actually failed for this pull request in Froto.Parser.Test, so I'm going to |
ctaggart
added a commit
that referenced
this pull request
Mar 19, 2019
* add Nerdbank.GitVersioning * temp remove SourceLink * try switching Froto.Parser.Test from netsoreapp2.0 to 2.1 * use Froto.sln * latest dotnet 2.2.3 * try 2.2.2 * sdk is 2.2.105 * dist: xenial * remove Froto.TypeProvider from Froto.sln * back to netcoreapp2.0 * git fetch --unshallow * Revert "fix Enum in message body error (#96)" This reverts commit 40a86c7. * add version.json * disable nbgv for exe * use previous SourceLink dotnet/sourcelink#236 * PrivateAssets="All" * upgrade to Nerdbank.GitVersioning" Version="2.3.136 * remove Break()
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #93