Skip to content

Commit

Permalink
Changing defaults to None as lists were incomplete and the underlying…
Browse files Browse the repository at this point in the history
… pulse build monitor use None to default to all.
  • Loading branch information
lewchuk committed Oct 10, 2011
1 parent 8af09cb commit 310278b
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions harvester.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#
# Contributor(s):
# Clint Talbert <ctalbert@mozilla.com>
# Stephen Lewchuk <slewchuk@mozilla.com>
#
# Alternatively, the contents of this file may be used under the terms of
# either the GNU General Public License Version 2 or later (the "GPL"), or
Expand Down Expand Up @@ -54,12 +55,10 @@ def __init__(self, **kwargs):
defaults['tree'] = 'mozilla-central'

self.add_option('--platforms', action="store", type = "string",
dest='platforms', help = "Comma separated list of platforms to pull builds for - defaults to all")
defaults['platforms'] = 'linux,linux64,win32,win64,macosx,macosx64'
dest='platforms', help = "Comma separated list of platforms to pull builds for - defaults to all with blank spec")

self.add_option('--buildtype', action="store", type="string",
dest="buildtype", help = "Either opt,dbg build to pull from, defaults to all")
defaults["buildtype"] = 'debug,opt'
dest="buildtype", help = "Either opt,dbg build to pull from, defaults to all with blank spec")

self.add_option('--testlist', action='store', type='string',
dest='testlist', help="Comma separated list of test types to harvest logs for, defaults to talos")
Expand Down Expand Up @@ -105,8 +104,8 @@ def main():
parser = HarvesterOptions()
options, args = parser.parse_args()
tree = options.tree.split(',')
platforms = options.platforms.split(',')
buildtype = options.buildtype.split(',')
platforms = options.platforms and options.platforms.split(',') or None
buildtype = options.buildtype and options.buildtype.split(',') or None
testlist = options.testlist.split(',')
h = Harvester(tree, platforms, buildtype, testlist)

Expand Down

0 comments on commit 310278b

Please sign in to comment.