Reload rules while profiling #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jw3
commented
Jan 10, 2024
| @@ -197,7 +197,7 @@ def __pack_main_content(self, page: UIPage): | |||
| page.dispose() | |||
| return | |||
|
|
|||
| if self.__page: | |||
| if self.__page is not None: | |||
There was a problem hiding this comment.
Cause of split view when navigating away from rule view after Events was mixed in.
The type after Event mixin must not have had a bool ability. It also didnt have a string rep, perhaps that was one in the same with the bool rep.
Checking for not None here is appropriate regardless, since there is not a valid bool rep of a page.
jw3
added a commit
to jw3/fapolicy-analyzer
that referenced
this pull request
Jan 22, 2024
Allow rules to be loaded dynamically into a profiling session. This allows for a better test / update cycle while profiling as the profiler does not have to be shutdown to update rules. This also adds a new concept, the "Rule Identity", which provides a sha256 hash of the rule database to allow change monitoring across both profiler and systemd daemon execution. This hash is based on the compiled rules to provide a precise content based hash. Closes ctc-oss#985 Closes ctc-oss#989 # Conflicts: # crates/pyo3/Cargo.toml
Merged
jw3
added a commit
that referenced
this pull request
Jan 22, 2024
Merged
jw3
added a commit
that referenced
this pull request
Feb 11, 2024
## [v1.3.0](https://github.com/ctc-oss/fapolicy-analyzer/releases/tag/v1.3.0) - 2024-02-11 ### Added - Allow rules to be loaded dynamically into a profiling session ([#990](#990)) - Added syntax highlighting to the fapolicyd config editor ([#991](#991)) ### Packaging - Use digest crate for sha256 hashing, removing need for ring crate. ([#984](#984)) - Add a version number to the PDF user guide content and filename. ([#995](#995))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow rules to be loaded dynamically into a profiling session.
This allows for a better test / update cycle while profiling as the profiler does not have to be shutdown to update rules.
This also adds a new concept, the "Rule Identity", which provides a sha256 hash of the rule database to allow change monitoring across both profiler and systemd daemon execution. This hash is based on the compiled rules to provide a precise content based hash.
Closes #985
Closes #989