Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow connection_info for container challenges #120

Closed
pl4nty opened this issue Jul 16, 2023 · 1 comment · Fixed by #121
Closed

Allow connection_info for container challenges #120

pl4nty opened this issue Jul 16, 2023 · 1 comment · Fixed by #121

Comments

@pl4nty
Copy link
Contributor

pl4nty commented Jul 16, 2023

connection_info for container challenges is currently set by the deployment handler. It would be helpful to be able to override this in challenge.yml for certain challenges.

ctfcli/ctfcli/cli/challenges.py

Line 340 in de3dcee

challenge["connection_info"] = connect_info

@ColdHeat
Copy link
Member

Makes sense, feel free to submit a PR for this if you can. I think if specified the connection info in challenge.yml should take priority.

@pl4nty pl4nty mentioned this issue Jul 17, 2023
Merged
ColdHeat added a commit that referenced this issue Jul 27, 2023
@pl4nty @ColdHeat
Allow provided connection_info in deploy (#121)
1c11ea6 
* feat: allow provided `connection_info` in `deploy`

* Add some logging information to show that we will use hardcoded connection_info

* Fixes #120 

---------

Co-authored-by: Kevin Chung <kchung@ctfd.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow provided connection_info in deploy pl4nty/ctfcli
2 participants
@ColdHeat @pl4nty