Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created zip's under Windows are corrupt #130

Closed
blakemcbride opened this issue Mar 12, 2015 · 14 comments
Closed

Created zip's under Windows are corrupt #130

blakemcbride opened this issue Mar 12, 2015 · 14 comments

Comments

@blakemcbride
Copy link

I did the following to create a zip file:

var zip = new AdmZip();
zip.addLocalFolder(dir);
zip.writeZip(zipfilename);

It worked fine under Linux & Mac but the zip file had garbage under Windows.

@neocotic
Copy link

I'm also seeing this, which is strange as I know this used to work fine and suddenly, within the last month, it's breaking. I'm assuming due to problems with the latest release.

ZIP tools (including Window's own) are treating the files that I added as folders. The size of the ZIP file is as I'd expect, but the entries are no longer being added correctly. Could this be related to the recent changes I've seen related to attr for entries?

@wiedikerli
Copy link

ZIP tools (including Window's own) are treating the files that I added as folders.

also have this problem...

@adenhertog
Copy link

I'm getting the same issue. Windows 8.1, zip files appear empty though they are the expected size. Rolling back to v0.4.4 works for me.

@houssemFat
Copy link

I confirm, all files are converted to empty folders (Windows 8.1)

@teu
Copy link

teu commented Apr 9, 2015

Hi, getting this problem under Ubuntu Linux too.

@rajojon23
Copy link

not working for me as well in Windows 8.1 (corrupted file message)

@houssemFat
Copy link

the @adenhertog solution works for me also, consider Rolling back to v0.4.4

@blakemcbride
Copy link
Author

Since the author won't fix the problem, I fixed it by switching to zip-folder. That works flawlessly on Linux, Mac & Windows.

@wiedikerli
Copy link

Jap, you guys should switch to an other zipper. I successfuly changed to https://github.com/archiverjs/node-archiver

@theo-armour
Copy link

thanks @blakemcbride, https://www.npmjs.com/package/zip-folder works for me too, though slightly inconvenient for me as I have to create a directory first.

Still using adm-zip to extract files. Would be nice to see this issue fixed...

@lloiser
Copy link
Contributor

lloiser commented May 23, 2015

this issue is actually fixed with eb92910
unfortunately 06e1f68 breaks this lib again if you call addLocalFolder it again. I have fixed this problem with my pull request.
So we only have to wait for my pull request to get merged and a new version pushed to npm

@bengle
Copy link

bengle commented Jul 6, 2015

@blakemcbride, Thanks,it works well!

@jdrake
Copy link

jdrake commented Sep 14, 2015

Thanks @ninjaonsafari that worked for me. Took like a minute to swap out.

@urish
Copy link

urish commented Sep 27, 2015

Also faced this issue, ended up using archiver instead.

cthackers added a commit that referenced this issue Nov 22, 2017
inga-lovinde added a commit to inga-lovinde/micro-build-server that referenced this issue Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests