Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormData multi-part handling #202

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

burgalon
Copy link

No description provided.

@burgalon burgalon force-pushed the form-data branch 3 times, most recently from 45b11be to ab34875 Compare April 28, 2019 10:38
@@ -64,6 +64,26 @@ function isParametersMatching(parameters, required) {
}

function isBodyMatching(body, requiredBody) {
if (requiredBody instanceof FormData) {
Copy link
Collaborator

@marcbachmann marcbachmann Apr 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instanceof checks won't work as only one specific version of the module would be handled.
This would probably need some kind of duck typing.
Also, FormData isn't global in node <18.0.0, so this will break the module for older versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants