Added support for multiple progress bars displayed simultaneously #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arted from multiple threads / concurrently) - defaults to "single line" behavior when terminal does not support moving cursor - using ScheduledThreadPoolExecutor with single daemon thread (that does not prevent the JVM from exiting) - simplifies thread-safety and ensures only single thread is moving cursor
- moving cursor up/down only based on the fact how many active progress bars are currently being rendered (instead of getting current cursor position in order to attempt to "re-render" correct line in console - which breaks instantly on terminal re-size)
|
I've tested on Windows 10:
MacOS:
Centos7:
|
|
Wow! Thanks @vehovsky !!! |
|
I've used this simple code to verify on the different envs: progressbas-multiline-example |
- no need for entering terminal raw mode (needed when asking terminal for cursor position) - basic terminal info (width / cursor movement support) are now public - helps when writing custom ProgressBarConsumer
vehovsky
commented
Apr 11, 2020
| @@ -123,7 +123,7 @@ public ProgressBar( | |||
| @Deprecated | |||
| public ProgressBar start() { | |||
There was a problem hiding this comment.
Honestly I don't see point in keeping this deprecated method in the public API. There is no way anymore (even before this PR) to construct the ProgressBar without the Runnable being started. Personally I would remove it and made the updateInterval private again in ProgressThread.
…e consumer
- currently was not the case and could cause display issue in terminals without cursor movement support (when multiple progress bars were started in parallel)
- as the final "new line" was being writen to PrintStream from different thread
- other refactorings
- ensure new terminal is not created on every progress bar re-render - at the same time ensure only single instance of Terminal was build - every ProgressBar can't hold instance of Terminal, although it's possible to create multiple instances of Terminal, subsequent instance are created as "dumb" until the first instance is closed
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11