Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

foreign key change of type don't get noticed #570

Closed
n-epifanov opened this issue Aug 2, 2018 · 7 comments · Fixed by #678
Closed

foreign key change of type don't get noticed #570

n-epifanov opened this issue Aug 2, 2018 · 7 comments · Fixed by #678
Labels
bug help-wanted reviewed

Comments

@n-epifanov
Copy link

Commands

When I change foreign key type from :restrict to :cascade or back
in e.g. Rails migration:

      remove_foreign_key :imports, :clients
      add_foreign_key :imports, :clients, on_delete: :cascade

then run
bundle exec annotate
I get
Model files unchanged.
And it's at outdated

# Foreign Keys
#
#  fk_rails_...  (client_id => clients.id) ON DELETE => restrict

Only running with --force updates them properly.

Version

  • annotate v2.7.4
  • Rails 5.2.0
  • ruby 2.5.1p57 (2018-03-29 revision 63029) [x86_64-linux]
@ctran
Copy link
Owner

ctran commented Feb 14, 2019

Is it possible to give me a complete model to reproduce this? Even better if you can update one of the existing test cases.

@ctran ctran added the reviewed label Feb 14, 2019
@n-epifanov
Copy link
Author

Ok, I'll try to add a test for this.

@n-epifanov n-epifanov mentioned this issue Feb 18, 2019
Open
@n-epifanov
Copy link
Author

Done.

@drwl
Copy link
Collaborator

drwl commented Apr 28, 2019

@NickTime So the test added in #601 highlights a bug that needs to be addressed?

@n-epifanov
Copy link
Author

@drwl That's right.

@drwl drwl added the bug label Apr 29, 2019
@drwl
Copy link
Collaborator

drwl commented Apr 29, 2019

Thanks for adding the test. I've marked this as a bug and will wait off on merging the test until there's an appropriate fix, as otherwise it'll fail builds going forward.

@n-epifanov
Copy link
Author

Sure, you're welcome.

sashabelozerov added a commit to sashabelozerov/annotate_models that referenced this issue Oct 26, 2019
@sashabelozerov
[Fix ctran#570] Change of foreign key should be considered as a colum…
5e9dc65 
…n change
@sashabelozerov sashabelozerov mentioned this issue Oct 26, 2019
Merged
ctran pushed a commit that referenced this issue Dec 18, 2019
@sashabelozerov @ctran
[Fix #570] Change of foreign key should be considered as a column cha…
5219c7e 
…nge (#678)
peterfication pushed a commit to store2be/annotate_models that referenced this issue Jan 20, 2020
@sashabelozerov @peterfication
[Fix ctran#570] Change of foreign key should be considered as a colum…
d488990 
…n change (ctran#678)
vfonic pushed a commit to vfonic/annotate_models that referenced this issue May 8, 2020
@sashabelozerov @vfonic
[Fix ctran#570] Change of foreign key should be considered as a colum…
a68493a 
…n change (ctran#678)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help-wanted reviewed
Projects
None yet
Milestone
No milestone
3 participants
@ctran @n-epifanov @drwl