Refactor RSpec for AnnotateModels - structuralize test cases #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the primary key is not specified
…ion "show_indexes" is true
|
Please review with option 'ignore whitespaces' (or add Commits with message begin with "Move ~" is just by cut and paste. |
nard-tech
force-pushed
the
feature/refactor_annotate_models/rspec_v6
branch
from
ee6b2a1
to
8304e02
Compare
nard-tech
force-pushed
the
feature/refactor_annotate_models/rspec_v6
branch
from
8304e02
to
9695b9b
Compare
|
seattlerb/sexp_processor was fixed and CI have passed. Please review this PR. |
nard-tech
changed the title
drwl
approved these changes
Feb 13, 2020
|
@drwl I fixed conflict due to |
vfonic
pushed a commit
to vfonic/annotate_models
that referenced
this pull request
May 8, 2020
The test cases of AnnotateModels.get_schema_info was separated into two sections. So I merged them into one, and refactor test cases. This PR is new version of ctran#741.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test cases of AnnotateModels.get_schema_info was separated into two sections.
So I merged them into one, and refactor test cases.
This PR is new version of #741.