-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor RSpec for AnnotateModels - structuralize test cases #755
Refactor RSpec for AnnotateModels - structuralize test cases #755
Conversation
… the primary key is not specified
…ion "show_indexes" is true
Please review with option 'ignore whitespaces' (or add Commits with message begin with "Move ~" is just by cut and paste. |
ee6b2a1
to
8304e02
Compare
8304e02
to
9695b9b
Compare
seattlerb/sexp_processor was fixed and CI have passed. Please review this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🙌. Thanks for structuralizing the test cases. Could you fix merge conflict then tag me?
@drwl I fixed conflict due to |
The test cases of AnnotateModels.get_schema_info was separated into two sections. So I merged them into one, and refactor test cases. This PR is new version of ctran#741.
The test cases of AnnotateModels.get_schema_info was separated into two sections.
So I merged them into one, and refactor test cases.
This PR is new version of #741.