Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RSpec for AnnotateModels - structuralize test cases #755

Merged
merged 18 commits into from
Feb 13, 2020
Merged

Refactor RSpec for AnnotateModels - structuralize test cases #755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
050726a
Add context 'when option is not present’ and refactor test cases when…
nard-tech Feb 8, 2020
71ed751
Move test cases when the primary key is specified
nard-tech Feb 8, 2020
741c813
Add context 'when option is present' and refactor test cases when opt…
nard-tech Feb 8, 2020
e54109b
Move test cases when option "simple_indexes" is true
nard-tech Feb 8, 2020
d33b277
Move test cases when foreign keys exist
nard-tech Feb 8, 2020
d9618a0
Move test cases with Globalize gem
nard-tech Feb 8, 2020
536b6f8
Move test cases when the primary key is an array (using composite_pri…
nard-tech Feb 8, 2020
dfb04ed
Move test cases when header is "== Schema Information"
nard-tech Feb 8, 2020
7263d55
Refactor options of AnnotateModels.get_schema_info
nard-tech Feb 8, 2020
96e5e02
Move test cases when "hide_limit_column_types" is specified in options
nard-tech Feb 8, 2020
c781605
Move test cases when "hide_default_column_types" is specified in options
nard-tech Feb 8, 2020
bdaa07b
Move test cases 'when "classified_sort" is specified in options'
nard-tech Feb 8, 2020
ecb2a0b
Move test cases when "with_comment" is specified in options
nard-tech Feb 8, 2020
5464b75
Move test cases when "format_doc" and "with_comment" are specified in…
nard-tech Feb 8, 2020
227e80c
Move test cases when "format_markdown" and "with_comment" are specifi…
nard-tech Feb 8, 2020
9695b9b
Execute `rubocop --auto-gen-config`
nard-tech Feb 8, 2020
6d1e32b
Execute `rubocop --auto-gen-config`
nard-tech Feb 10, 2020
497e91c
Merge branch 'develop' into feature/refactor_annotate_models/rspec_v6
nard-tech Feb 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2020-02-12 18:43:06 +0900 using RuboCop version 0.68.1.
# on 2020-02-13 18:10:52 +0900 using RuboCop version 0.68.1.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand Down Expand Up @@ -528,7 +528,7 @@ Style/UnneededPercentQ:
Exclude:
- 'annotate.gemspec'

# Offense count: 344
# Offense count: 346
# Cop supports --auto-correct.
# Configuration parameters: AutoCorrect, AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
# URISchemes: http, https
Expand Down
Loading