Fix cpants issue #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The tests are currently failing, if you wish for this to merged please resolve this issue. Can you help me understand the value added by including the MinimumPerlFast dzil plugin? |
|
Hi, with regard to the failure, I see why it is failing. The plugin [PodVersion] expect every package to have "=head1 NAME". Since it couldn't find it the listed packages, we see the failed message. If you want I am more than happy to fix the issue/ with regard to the importance of having "minimum perl version" in the distribution, I would recommend this blog by Neil Bowers: Best Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ctriv
Please review the PR addressing issues raised by CPANTS.
http://cpants.cpanauthors.org/dist/Monorail
Many Thanks.
Best Regards,
Mohammad S Anwar