Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update reactotron recipe #776

Merged
merged 2 commits into from
Oct 26, 2022
Merged

Conversation

jmyrland
Copy link
Collaborator

Based on the existing docs & this SO post.

closes #757

@vercel
Copy link

vercel bot commented Sep 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
easy-peasy ✅ Ready (Inspect) Visit Preview Oct 25, 2022 at 3:09PM (UTC)

@jmyrland jmyrland changed the title Update reactotron recipe docs: Update reactotron recipe Sep 21, 2022
@jmyrland
Copy link
Collaborator Author

I've excluded the window.requestIdleCallback = null; which might be essential for it to work on iOS.

  1. Should we include it in the recipe?
  2. Should we try to find a solution for this issue

@ctrlplusb
Copy link
Owner

Awesome. Perhaps we can just add a comment stating the potential issues around iOS with a link to the corresponding issue/discussion?

@jmyrland
Copy link
Collaborator Author

Awesome. Perhaps we can just add a comment stating the potential issues around iOS with a link to the corresponding issue/discussion?

Added the "solution" as part of the snippet, with a link back to the issue

Copy link
Owner

@ctrlplusb ctrlplusb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@jmyrland jmyrland merged commit b0a44c4 into master Oct 26, 2022
@jmyrland jmyrland deleted the docs/update-reactotron-recipe branch October 26, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to add reactron
2 participants