This repository has been archived by the owner on Jun 3, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ender deprecates in 17.
…dir, as its no longer an option. HappyPack threadpool now is decided based off of os.cpus().length
…vious addons packages. moved meta charSet above title in html template
…adapter-react-16 and a setupFile for jest tests
…o satisfy airbnb peer dep
Legendary @strues thanks! |
ctrlplusb
approved these changes
Oct 3, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
@strues are you using on production? i want to make a deploy to production in the next weeks 🤓 |
As usual, awesome work @strues |
@strues When using this in conjunction with the redux branch, I get the following error on the `/posts/2' page: Warning: WithJob(Post).componentWillMount(): Assigning directly to this.state is
deprecated (except inside a component's constructor). Use setState instead. @ctrlplusb Is this a |
ctrlplusb
pushed a commit
that referenced
this pull request
Oct 16, 2017
* switch reactdom.render to reactdom.hydrate as per react 16 changes. render deprecates in 17. * remove extraneous babel-polyfill * Update dependencies, included is HappyPack 4. Removed Happypack temp dir, as its no longer an option. HappyPack threadpool now is decided based off of os.cpus().length * remove react-addons-test-utils as React 16 doesnt use any form of previous addons packages. moved meta charSet above title in html template * Add requestAnimationFrame (raf) polyfill. Upgrade enzyme. Add enzyme-adapter-react-16 and a setupFile for jest tests * bump react-hot-loader to beta 7. downgrade eslint/jsx-a11y to 5.1.1 to satisfy airbnb peer dep
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
switch ReactDOM.render to ReactDOM.hydrate as per React 16 changes. render deprecates in React 17.
remove extraneous
babel-polyfill
(doesnt break tests or have any effect).Update dependencies, included is HappyPack 4. HappyPack thread pool is set by
os.cpus().length
remove react-addons-test-utils as React 16 doesnt use any form of previous addons packages. moved meta charSet above title in html template
Add requestAnimationFrame (raf) polyfill to
client/polyfill.js
.Upgrade enzyme. Add
enzyme-adapter-react-16
and a setupFile for jest tests. See enzyme adapter docs