Skip to content
This repository has been archived by the owner on Jun 3, 2019. It is now read-only.

Next updates #510

Merged
merged 6 commits into from
Oct 3, 2017
Merged

Next updates #510

merged 6 commits into from
Oct 3, 2017

Conversation

strues
Copy link
Collaborator

@strues strues commented Oct 3, 2017

  • switch ReactDOM.render to ReactDOM.hydrate as per React 16 changes. render deprecates in React 17.

  • remove extraneous babel-polyfill (doesnt break tests or have any effect).

  • Update dependencies, included is HappyPack 4. HappyPack thread pool is set by os.cpus().length

  • remove react-addons-test-utils as React 16 doesnt use any form of previous addons packages. moved meta charSet above title in html template

  • Add requestAnimationFrame (raf) polyfill to client/polyfill.js.

  • Upgrade enzyme. Add enzyme-adapter-react-16 and a setupFile for jest tests. See enzyme adapter docs

Steven Truesdell added 6 commits October 2, 2017 21:34
…dir, as its no longer an option. HappyPack threadpool now is decided based off of os.cpus().length
…vious addons packages. moved meta charSet above title in html template
…adapter-react-16 and a setupFile for jest tests
@ctrlplusb
Copy link
Owner

Legendary @strues thanks!

Copy link
Owner

@ctrlplusb ctrlplusb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@sergiokopplin
Copy link
Collaborator

@strues are you using on production? i want to make a deploy to production in the next weeks 🤓

@strues strues merged commit 1688a1c into ctrlplusb:next Oct 3, 2017
@oyeanuj oyeanuj mentioned this pull request Oct 5, 2017
@diondirza
Copy link
Contributor

As usual, awesome work @strues

@oyeanuj
Copy link
Contributor

oyeanuj commented Oct 6, 2017

@strues When using this in conjunction with the redux branch, I get the following error on the `/posts/2' page:

Warning: WithJob(Post).componentWillMount(): Assigning directly to this.state is 
deprecated (except inside a component's constructor). Use setState instead.

@ctrlplusb Is this a react-jobs error instead?

ctrlplusb pushed a commit that referenced this pull request Oct 16, 2017
* switch reactdom.render to reactdom.hydrate as per react 16 changes. render deprecates in 17.

* remove extraneous babel-polyfill

* Update dependencies, included is HappyPack 4. Removed Happypack temp dir, as its no longer an option. HappyPack threadpool now is decided based off of os.cpus().length

* remove react-addons-test-utils as React 16 doesnt use any form of previous addons packages. moved meta charSet above title in html template

* Add requestAnimationFrame (raf) polyfill. Upgrade enzyme. Add enzyme-adapter-react-16 and a setupFile for jest tests

* bump react-hot-loader to beta 7. downgrade eslint/jsx-a11y to 5.1.1 to satisfy airbnb peer dep
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants