Split ctrlp#setlines() for ctrlp#init(). Fixes ctrlpvim/ctrlp.vim#463 #488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Issue:
Opening "ctrlp" in certain modes (':CtrlPBufTag', ':CtrlPLine') seems to
trigger a partially deffective intialisation (for example, syntax
highlighting not working as expected).
* Changes:
ctrlp#setlines() has been split in two, as the second part (now in
s:setlines_post()) seems to need '&filetype', and s:DetectFileType()
seems to need the first part of the old ctrlp#setlines() (now in
s:setlines_pre()).
|
For more details on the fix itself, please see the thread in #463. |
|
Thanks for your PR. |
|
Good to merge? |
|
It's good to go from my pov.
|
|
Thank you |
|
Thank you for merging this 👍. I've got a number of fixes for other issues I've encountered, so this merge is encouraging 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening
ctrlpin certain modes (:CtrlPBufTag,:CtrlPLine) seems totrigger a partially deffective intialisation (for example, syntax
highlighting not working as expected).
ctrlp#setlines()has been split in two, as the second part (now ins:setlines_post()) seems to need&filetype, ands:DetectFileType()seems to need the first part of the old
ctrlp#setlines()(now ins:setlines_pre()).