Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable mounting an existing bucket #55 #60

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Conversation

defrox
Copy link
Contributor

@defrox defrox commented Dec 7, 2021

As requested in #55 , this mod allows to create a Storage Class that configured properly allows to be mounted on any existing bucket and/or prefix.

closes #55

@lynnmatrix
Copy link
Contributor

/lgtm

@defrox
Copy link
Contributor Author

defrox commented Jan 28, 2022

@ctrox please review this PR and merge if appropriate, thanks!

Copy link
Owner

@ctrox ctrox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and sorry for not getting back to you earlier. Left a few comments, would also appreciate if you could rebase as I think github actions should now properly run on your PR.

pkg/driver/controllerserver.go Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
pkg/s3/client.go Outdated Show resolved Hide resolved
pkg/driver/controllerserver.go Outdated Show resolved Hide resolved
@Christian-TD
Copy link

Thanks for the PR and sorry for not getting back to you earlier. Left a few comments, would also appreciate if you could rebase as I think github actions should now properly run on your PR.

@ctrox Rebased and applied commented changes, please review, thanks!

@ctrox ctrox merged commit 354d932 into ctrox:master Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mount existing bucket and access the data already in the bucket
4 participants