-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docking for Vertical SplitPanel #2785
Add docking for Vertical SplitPanel #2785
Conversation
modules/gui/src/com/haulmont/cuba/gui/components/SplitPanel.java
Outdated
Show resolved
Hide resolved
modules/web-widgets/src/com/haulmont/cuba/web/widgets/client/split/SplitPanelDockMode.java
Outdated
Show resolved
Hide resolved
modules/web/src/com/haulmont/cuba/web/gui/components/WebSplitPanel.java
Outdated
Show resolved
Hide resolved
modules/web/src/com/haulmont/cuba/web/gui/components/WebSplitPanel.java
Outdated
Show resolved
Hide resolved
Hi @koca2000, Thank you for your PR. Could you please take a look at my review comments? Regards, |
Hi @glebfox! I made changes you suggested. I also renamed Best regards, |
Hi @koca2000, the changes are correct. The last thing that I found is that you need to add available dock modes to the XSD definition of
|
Hi @glebfox, I added the values to XSD definition. |
Until now SplitPanel component only support docking for
Horizontal
orientation. This PR adds support for docking withVertical
orientation.