Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docking for Vertical SplitPanel #2785

Merged
merged 3 commits into from
Apr 22, 2020
Merged

Add docking for Vertical SplitPanel #2785

merged 3 commits into from
Apr 22, 2020

Conversation

koca2000
Copy link
Contributor

Until now SplitPanel component only support docking for Horizontal orientation. This PR adds support for docking with Vertical orientation.

@glebfox
Copy link
Member

glebfox commented Apr 7, 2020

Hi @koca2000,

Thank you for your PR. Could you please take a look at my review comments?

Regards,
Gleb

@koca2000
Copy link
Contributor Author

Hi @glebfox!

I made changes you suggested. I also renamed CubaHorizontalSplitPanelServerRpc to CubaDockableSplitPanelServerRpc as it more corresponds to it's usage.

Best regards,
koca2000

@koca2000 koca2000 requested a review from glebfox April 11, 2020 11:54
@glebfox
Copy link
Member

glebfox commented Apr 14, 2020

Hi @koca2000, the changes are correct. The last thing that I found is that you need to add available dock modes to the XSD definition of split. They are located in the layout.xsd file in <xs:simpleType name="splitPanelDockMode"> element. Currently, it contains only: LEFT and RIGHT.

<xs:simpleType name="splitPanelDockMode">
    <xs:restriction base="xs:string">
        <xs:enumeration value="LEFT"/>
        <xs:enumeration value="RIGHT"/>
    </xs:restriction>
</xs:simpleType>

@koca2000
Copy link
Contributor Author

Hi @glebfox, I added the values to XSD definition.

@glebfox glebfox merged commit 3c79264 into cuba-platform:master Apr 22, 2020
@haulmont-git haulmont-git added the ver: 7.3.0 Fixed in version label Apr 22, 2020
glebfox pushed a commit that referenced this pull request Apr 22, 2020
@haulmont-git haulmont-git added the ver: 7.2.4 Fixed in version label Apr 22, 2020
@natfirst natfirst added the state: fixed Fixed by the developer label Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: fixed Fixed by the developer ver: 7.2.4 Fixed in version ver: 7.3.0 Fixed in version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants