Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support casting from/to Null #31

Merged
merged 3 commits into from
Feb 5, 2024

Conversation

MazterQyou
Copy link
Member

This PR cherry-picks a commit allowing Null casting, adding support for Null ordering and Decimal-Null casts on top of it. Related tests are included.

WinkerDu and others added 3 commits January 19, 2024 13:21
* cast null from and to others

* fmt fix

* add more ut

Co-authored-by: duripeng <duripeng@baidu.com>
@github-actions github-actions bot added the arrow label Jan 19, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 19, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7e9519c) 82.76% compared to head (4f1434c) 82.81%.

❗ Current head 4f1434c differs from pull request most recent head 31c0d8f. Consider uploading reports for the commit 31c0d8f to get more accurate results

Files Patch % Lines
arrow/src/array/ord.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           cubesql-v11.1.0      #31      +/-   ##
===================================================
+ Coverage            82.76%   82.81%   +0.04%     
===================================================
  Files                  190      190              
  Lines                55351    55376      +25     
===================================================
+ Hits                 45811    45858      +47     
+ Misses                9540     9518      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MazterQyou MazterQyou merged commit 9f2e286 into cubesql-v11.1.0 Feb 5, 2024
29 checks passed
@MazterQyou MazterQyou deleted the cubesql/null-type-support branch February 5, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants