fix(Form): avoid creating fields with empty names

cube-js · Jul 12, 2023 · f33bd19 · f33bd19
1 parent eea93f2
commit f33bd19
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/components/forms/Form/ComplexForm.stories.tsx b/src/components/forms/Form/ComplexForm.stories.tsx
@@ -92,7 +92,7 @@ const CustomSubmitErrorTemplate: StoryFn<typeof Form> = (args) => {
         <TextInput />
       </Field>
       <Submit>Submit</Submit>
-      {form.submitError ? <Alert>{form.submitError}</Alert> : null}
+      {form.submitError ? <Alert>{form.submitError as string}</Alert> : null}
     </Form>
   );
 };

diff --git a/src/components/forms/Form/Form.tsx b/src/components/forms/Form/Form.tsx
@@ -163,7 +163,6 @@ function Form<T extends FieldTypes>(
         try {
           await form.validateFields();
         } catch (e) {
-          console.error('!', e);
           form?.setSubmitting(false);
 
           return;

diff --git a/src/components/forms/Form/use-form.tsx b/src/components/forms/Form/use-form.tsx
@@ -324,6 +324,11 @@ export class CubeFormInstance<
   }
 
   createField<Name extends keyof T & string>(name: Name, skipRender?: boolean) {
+    // passing an empty name is incorrect, but we have to return a valid object to avoid inconsistency
+    if (!name) {
+      return this._createField(name);
+    }
+
     if (!this.fields[name]) {
       this.fields[name] = this._createField(name);
     }
@@ -369,7 +374,6 @@ export class CubeFormInstance<
     name: Name,
     data?: Data,
   ): Data {
-    console.error('! create field', name, data);
     let obj = {
       name,
       validating: false,