Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

continueWaitTimeout is ignored (redis) #225

Closed
vieira opened this issue Oct 3, 2019 · 1 comment
Closed

continueWaitTimeout is ignored (redis) #225

vieira opened this issue Oct 3, 2019 · 1 comment
Labels
bug Something isn't working help wanted Community contributions are welcome.

Comments

@vieira
Copy link
Contributor

vieira commented Oct 3, 2019

Describe the bug
Even though I defined continueWaitTimeout to be 120 the "Continue wait" response is sent after ~5s (the default).

To Reproduce
Steps to reproduce the behavior:

  1. Initialize CubejsServerCore defining the continueWaitTimeout to some value different than the default (5).
CubejsServerCore.create({
  ...
  orchestratorOptions: {
    queryCacheOptions: {
      queueOptions: {
        continueWaitTimeout: 120,
      },
    },
    preAggregationsOptions: {
      queueOptions: {
        continueWaitTimeout: 120,
      },
  },
});
  1. Make a REST API call resulting in a query that takes more than 5s to run.
  2. Notice a Continue wait response after 5s. (Also visible in the logs, screenshot below).

Expected behavior
I expected to receive a Continue Wait response only after the configured continueWaitTimeout.

Screenshots
Screen Shot 2019-10-04 at 00 47 20

Version:
@cubejs-backend/server-core: 0.10.46

Notes:
This might be related to #224 but is also happening in production where redis is being used, so I am not sure.

@vieira vieira changed the title continueWaitTimeout is ignored (redis) continueWaitTimeout is ignored (redis) Oct 4, 2019
@paveltiunov
Copy link
Member

paveltiunov commented Oct 4, 2019

@vieira I see. Seems like you expect to override api-gateway continue wait timeout which is not overridable right now:
https://github.com/cube-js/cube.js/blob/master/packages/cubejs-server-core/core/OrchestratorApi.js#L24

I think we can introduce some global continueWaitTimeout CubejsServerCore option which will be used here and by all queues by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Community contributions are welcome.
Projects
None yet
Development

No branches or pull requests

2 participants