Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made
I am not familiar with the internals of cube, however I am experiencing a problem where
continueWaitTimeout
is not being honored and upon inspecting the code it seems that the option is only used as a fallback to an argument that is never undefined.Furthermore it seems thar a pair of parentheses is missing (?) otherwise it will wait for 5ms instead of 5s.
I might be missing something as I am really not familiar with the code, please review.
Thank you.