Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cubestore-driver): Use ILIKE for contains filter #3502

Merged
merged 1 commit into from
Oct 1, 2021

Conversation

ovr
Copy link
Member

@ovr ovr commented Sep 30, 2021

Hello!

Cube.js has a contains filter which is a case insensitive filter (https://cube.dev/docs/query-format/#contains). Starting from v0.28.37 Cube Store started to support ILIKE operator (6a3fe64) which is the correct way to handle the contains filter.

Thanks

@ovr ovr requested a review from a team as a code owner September 30, 2021 12:49
@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #3502 (65edd97) into master (9357484) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3502      +/-   ##
==========================================
+ Coverage   59.77%   59.82%   +0.05%     
==========================================
  Files         124      124              
  Lines        9946     9946              
  Branches     2253     2253              
==========================================
+ Hits         5945     5950       +5     
+ Misses       3715     3710       -5     
  Partials      286      286              
Impacted Files Coverage Δ
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 64.41% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 996e65a...65edd97. Read the comment docs.

@paveltiunov paveltiunov merged commit c1b2e10 into master Oct 1, 2021
@paveltiunov paveltiunov deleted the cubestore-contains-use-ilike branch October 1, 2021 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants