fix: Cleanup redis pool properly in tests #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keydunov
added a commit
that referenced
this pull request
Mar 12, 2020
…b-analytics * 'web-analytics' of github.com:statsbotco/cube.js: (94 commits) Update dependencies Update dependencies Update web-analytics v0.18.0 fix: Redis query queue locking redesign Update Subquery.md tests: Cleanup redis pool properly in tests (#458) Debug CI Update client core dependency for vue tests Fix vue tests and client build Fix tests race conditions fix: Handle multiple occurrences in the first event of a funnel: conversion percent discrepancies. feat: Redis connection pooling (#433) Thanks to @jcw! build(deps): bump moment-range from 4.0.1 to 4.0.2 (#442) feat: Add role parameter to driver options (#448) Thanks to @smbkr! build(deps-dev): bump request from 2.88.0 to 2.88.2 (#441) build(deps): bump recharts from 1.7.1 to 1.8.5 (#446) build(deps): bump sqlite3 from 4.1.0 to 4.1.1 (#445) build(deps): bump tslib from 1.9.3 to 1.11.0 (#440) build(deps-dev): bump http-server from 0.11.1 to 0.12.1 (#437) ...
This was referenced Apr 26, 2021
This was referenced Jan 11, 2022
Open
Open
This was referenced Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
Fixes tests hanging
Description of Changes Made (if issue reference is not provided)
Was only cleaning up redis pool in one of two test files in Orchestrar, doh. No idea why specs passed on the original branch.