Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add role parameter to Snowflake driver options #448

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

smbkr
Copy link
Contributor

@smbkr smbkr commented Feb 26, 2020

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • [✓] Docs have been added / updated if required

Issue Reference this PR resolves

#447

Description of Changes Made (if issue reference is not provided)

  • Add CUBEJS_DB_SNOWFLAKE_ROLE as a config option
  • Add this to the docs

@smbkr smbkr changed the title Add role parameter to driver options Add role parameter to Snowflake driver options Feb 26, 2020
@paveltiunov
Copy link
Member

@smbkr Hey Stuart! Thanks for providing this one! Looks great!

@paveltiunov paveltiunov merged commit 9bfb71d into cube-js:master Feb 26, 2020
keydunov added a commit that referenced this pull request Mar 12, 2020
…b-analytics

* 'web-analytics' of github.com:statsbotco/cube.js: (94 commits)
  Update dependencies
  Update dependencies
  Update web-analytics
  v0.18.0
  fix: Redis query queue locking redesign
  Update Subquery.md
  tests: Cleanup redis pool properly in tests (#458)
  Debug CI
  Update client core dependency for vue tests
  Fix vue tests and client build
  Fix tests race conditions
  fix: Handle multiple occurrences in the first event of a funnel: conversion percent discrepancies.
  feat: Redis connection pooling (#433) Thanks to @jcw!
  build(deps): bump moment-range from 4.0.1 to 4.0.2 (#442)
  feat: Add role parameter to driver options (#448) Thanks to @smbkr!
  build(deps-dev): bump request from 2.88.0 to 2.88.2 (#441)
  build(deps): bump recharts from 1.7.1 to 1.8.5 (#446)
  build(deps): bump sqlite3 from 4.1.0 to 4.1.1 (#445)
  build(deps): bump tslib from 1.9.3 to 1.11.0 (#440)
  build(deps-dev): bump http-server from 0.11.1 to 0.12.1 (#437)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants