New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vertica-driver): VerticaDriver #7289
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Ignored Deployments
|
@timbrownls20 Thanks for contributing! Could you please write a readme on your npm package on how to install and use it? We'll add a backlink to it in the third-party driver list. |
No problem. Added instructions to README for the npm package. Wasn't sure what you wanted, so hope this is OK. If you need amends could you post a link to an example. Many Thanks |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #7289 +/- ##
==========================================
- Coverage 48.02% 47.04% -0.99%
==========================================
Files 154 155 +1
Lines 21019 20768 -251
Branches 5264 5224 -40
==========================================
- Hits 10095 9770 -325
+ Misses 10723 10678 -45
- Partials 201 320 +119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@timbrownls20 I actually meant README of |
No problem. README update in knowitall npm I've also updated the package refs in the PR to be Let me know if you need anything else. Thanks |
@timbrownls20 Great! Added it here https://cube.dev/docs/product/configuration/data-sources#third-party-drivers. What's the best way to communicate with you regarding issues? We'll start forwarding all conversations about this Vertica driver to you. |
I've had a shared mailbox set up for our development team. I'll assign a dev to answer queries as they come up - dev_kia@knowitall.net.au |
@paveltiunov there any ETA for merging this PR ? |
@guyzilb Did you have success using it as |
@igorlukanin |
* Added custom dialect for CubeDriver
Hi @guyzilb, in the latest commits on this branch we started to implement the SQL dialect. Do you know if there is an override on the BaseQuery that needs to be added for the timestamp and join conditions there perhaps?
|
@enhanse the join between preagg should be on a.user_id=b.user_id When Preagg runs some prefix is added to the column name so the join should be but what happened is : I hope I remember it well |
Check List
Issue Reference this PR resolves
[#690]
Description of Changes Made (if issue reference is not provided)
New @cubejs-backend/vertica-driver package based on vertica-nodejs -- it includes driver itself and basic tests for overridden BaseDriver methods.
published to npm
npm i @knowitall/vertica-driver
continuation of this stale PR #5100