Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vertica-driver): VerticaDriver #5100

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

korowa
Copy link

@korowa korowa commented Aug 14, 2022

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#690

Description of Changes Made (if issue reference is not provided)

New @cubejs-backend/vertica-driver package based on vertica-nodejs -- it includes driver itself and basic tests for overridden BaseDriver methods.

@korowa korowa requested review from a team as code owners August 14, 2022 11:45
@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Aug 14, 2022
@korowa korowa changed the title VerticaDriver implementation feat: VerticaDriver Aug 14, 2022
@korowa korowa changed the title feat: VerticaDriver feat(vertica-driver): VerticaDriver Aug 14, 2022
@codecov
Copy link

codecov bot commented Aug 15, 2022

Codecov Report

Base: 60.94% // Head: 60.08% // Decreases project coverage by -0.85% ⚠️

Coverage data is based on head (b50082a) compared to base (ccad5fc).
Patch has no changes to coverable lines.

❗ Current head b50082a differs from pull request most recent head 9d6f43f. Consider uploading reports for the commit 9d6f43f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5100      +/-   ##
==========================================
- Coverage   60.94%   60.08%   -0.86%     
==========================================
  Files         140      139       -1     
  Lines       12030    11568     -462     
  Branches     2953     2826     -127     
==========================================
- Hits         7332     6951     -381     
+ Misses       4395     4324      -71     
+ Partials      303      293      -10     
Flag Coverage Δ
cube-backend 60.08% <ø> (-0.86%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../cubejs-server-core/src/core/DriverDependencies.js 100.00% <ø> (ø)
packages/cubejs-backend-shared/src/env.ts 30.48% <0.00%> (-37.33%) ⬇️
...s/cubejs-schema-compiler/src/extensions/Funnels.ts 79.54% <0.00%> (-13.64%) ⬇️
...es/cubejs-schema-compiler/src/adapter/BaseQuery.js 68.42% <0.00%> (-2.02%) ⬇️
packages/cubejs-server-core/src/core/server.ts 66.36% <0.00%> (-1.30%) ⬇️
...bejs-schema-compiler/src/compiler/ErrorReporter.ts 75.00% <0.00%> (-1.28%) ⬇️
...s/cubejs-schema-compiler/src/adapter/BaseFilter.js 54.64% <0.00%> (-1.27%) ⬇️
...ges/cubejs-server-core/src/core/OrchestratorApi.ts 71.57% <0.00%> (-1.15%) ⬇️
packages/cubejs-api-gateway/src/gateway.ts 69.23% <0.00%> (-1.04%) ⬇️
...-query-orchestrator/src/orchestrator/QueryCache.ts 73.98% <0.00%> (-0.81%) ⬇️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hrmnjt
Copy link

hrmnjt commented Sep 30, 2022

@buntarb @cube-js/developer-relations-and-community
Bumping this up. What is the next step on this PR? Can we help somehow?

cc @martin-lofaj-maf

@korowa
Copy link
Author

korowa commented Sep 30, 2022

Sorry for that delay, I was waitnig for release of vertica-nodejs supporting node12 engine, and it seems it was released on npm ~2 weeks ago. I'll check it out this weekend and if it's fine, I'll push updates and resolve all conflicts in this PR.

@hrmnjt
Copy link

hrmnjt commented Oct 3, 2022

Thanks @korowa. We will wait for you to push updates.

@korowa
Copy link
Author

korowa commented Oct 4, 2022

@buntarb, could you please trigger "build" (I guess) workflow for this PR?

@paveltiunov
Copy link
Member

@korowa Thanks for contributing it! Could you please add the E2E test? You can use https://github.com/cube-js/cube.js/blob/master/packages/cubejs-testing/test/driver-questdb.test.ts as an example.

@hrmnjt
Copy link

hrmnjt commented Dec 8, 2022

@paveltiunov @korowa - sorry for bothering on this again. Are there any updates for this PR?

@hrmnjt
Copy link

hrmnjt commented Dec 29, 2022

@paveltiunov @korowa @buntarb - awaiting your kind help in getting this feature added to Cube. Please let me know if I can help in any way.

@paveltiunov
Copy link
Member

@korowa Could you please rebase your PR? We're also transitioning to a new driver contributing process. You can learn about it more here: https://github.com/cube-js/cube.js/blob/master/CONTRIBUTING.md#contributing-database-drivers. Could you please publish Vertica driver to npm while we're reviewing it?

@svdimchenko
Copy link

hi there! any updates regarding this PR ?

@halukakin
Copy link

Also interested in this. Look forward to using vertica with cube js.

@paveltiunov paveltiunov assigned paveltiunov and unassigned buntarb May 29, 2023
@justin-tomlinson
Copy link

looking for this also. our main db is vertica

@timbrownls20
Copy link

We'd like to look at completing this work. Should we open up a new PR when we've done it? Many Thanks

@igorlukanin
Copy link
Member

@timbrownls20 Sounds fantastic! Yep, please feel free to open a new PR

@timbrownls20
Copy link

Hi - raised a PR #7289 to complete this work. Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data source driver pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants