-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vertica-driver): VerticaDriver #5100
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportBase: 60.94% // Head: 60.08% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #5100 +/- ##
==========================================
- Coverage 60.94% 60.08% -0.86%
==========================================
Files 140 139 -1
Lines 12030 11568 -462
Branches 2953 2826 -127
==========================================
- Hits 7332 6951 -381
+ Misses 4395 4324 -71
+ Partials 303 293 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@buntarb @cube-js/developer-relations-and-community cc @martin-lofaj-maf |
Sorry for that delay, I was waitnig for release of vertica-nodejs supporting node12 engine, and it seems it was released on npm ~2 weeks ago. I'll check it out this weekend and if it's fine, I'll push updates and resolve all conflicts in this PR. |
Thanks @korowa. We will wait for you to push updates. |
@buntarb, could you please trigger "build" (I guess) workflow for this PR? |
@korowa Thanks for contributing it! Could you please add the E2E test? You can use https://github.com/cube-js/cube.js/blob/master/packages/cubejs-testing/test/driver-questdb.test.ts as an example. |
7a90f30
to
098f884
Compare
@paveltiunov @korowa - sorry for bothering on this again. Are there any updates for this PR? |
@paveltiunov @korowa @buntarb - awaiting your kind help in getting this feature added to Cube. Please let me know if I can help in any way. |
@korowa Could you please rebase your PR? We're also transitioning to a new driver contributing process. You can learn about it more here: https://github.com/cube-js/cube.js/blob/master/CONTRIBUTING.md#contributing-database-drivers. Could you please publish Vertica driver to npm while we're reviewing it? |
hi there! any updates regarding this PR ? |
Also interested in this. Look forward to using vertica with cube js. |
looking for this also. our main db is vertica |
We'd like to look at completing this work. Should we open up a new PR when we've done it? Many Thanks |
@timbrownls20 Sounds fantastic! Yep, please feel free to open a new PR |
Hi - raised a PR #7289 to complete this work. Cheers |
Check List
Issue Reference this PR resolves
#690
Description of Changes Made (if issue reference is not provided)
New @cubejs-backend/vertica-driver package based on vertica-nodejs -- it includes driver itself and basic tests for overridden BaseDriver methods.