Treat warnings as errors when running tests (#458)

* Treat user warnings as errors when running tests

* Fix Modal deprecation (Stub is now App)

* Dask test workflow should use dask distributed

.github/workflows/dask-tests.yml

@@ -38,7 +38,7 @@ jobs:
       - name: Install
         run: |
           python -m pip install --upgrade pip
-          python -m pip install -e '.[test-dask]'
+          python -m pip install -e '.[test-dask-distributed]'
 
       - name: Run tests
         run: |

cubed/runtime/executors/modal.py

@@ -23,7 +23,7 @@
 
 RUNTIME_MEMORY_MIB = 2000
 
-stub = modal.Stub("cubed-stub")
+app = modal.App("cubed-app")
 
 requirements_file = os.getenv("CUBED_MODAL_REQUIREMENTS_FILE")
 
@@ -72,7 +72,7 @@ def check_runtime_memory(spec):
             )
 
 
-@stub.function(
+@app.function(
     image=aws_image,
     secrets=[modal.Secret.from_name("my-aws-secret")],
     memory=RUNTIME_MEMORY_MIB,
@@ -87,7 +87,7 @@ def run_remotely(input, func=None, config=None, name=None, compute_id=None):
 
 
 # For GCP we need to use a class so we can set up credentials by hooking into the container lifecycle
-@stub.cls(
+@app.cls(
     image=gcp_image,
     secrets=[modal.Secret.from_name("my-googlecloud-secret")],
     memory=RUNTIME_MEMORY_MIB,
@@ -205,7 +205,7 @@ async def async_execute_dag(
 ) -> None:
     if spec is not None:
         check_runtime_memory(spec)
-    async with stub.run():
+    async with app.run():
         cloud = cloud or "aws"
         if cloud == "aws":
             app_function = run_remotely

cubed/tests/runtime/test_modal.py

@@ -15,7 +15,7 @@
 tmp_path = "s3://cubed-unittest/map_unordered"
 
 
-stub = modal.Stub("cubed-test-stub")
+app = modal.App("cubed-test-app")
 
 image = modal.Image.debian_slim().pip_install(
     [
@@ -33,7 +33,7 @@
 )
 
 
-@stub.function(
+@app.function(
     image=image,
     secrets=[modal.Secret.from_name("my-aws-secret")],
     retries=2,
@@ -43,14 +43,14 @@ def deterministic_failure_modal(i, path=None, timing_map=None, *, name=None):
     return deterministic_failure(path, timing_map, i, name=name)
 
 
-@stub.function(
+@app.function(
     image=image, secrets=[modal.Secret.from_name("my-aws-secret")], timeout=10
 )
 def deterministic_failure_modal_no_retries(i, path=None, timing_map=None, *, name=None):
     return deterministic_failure(path, timing_map, i, name=name)
 
 
-@stub.function(
+@app.function(
     image=image,
     secrets=[modal.Secret.from_name("my-aws-secret")],
     retries=2,
@@ -64,7 +64,7 @@ def deterministic_failure_modal_long_timeout(
 
 async def run_test(app_function, input, use_backups=False, batch_size=None, **kwargs):
     outputs = set()
-    async with stub.run():
+    async with app.run():
         async for output in map_unordered(
             app_function,
             input,

cubed/tests/test_executor_features.py

@@ -209,7 +209,6 @@ def test_compute_arrays_in_parallel_modal(modal_executor, compute_arrays_in_para
 
 
 def test_check_runtime_memory_dask(spec, executor):
-    pytest.importorskip("dask.distributed")
     if executor.name != "dask":
         pytest.skip(f"{executor.name} executor does not support check_runtime_memory")
 
@@ -228,7 +227,6 @@ def test_check_runtime_memory_dask(spec, executor):
 
 
 def test_check_runtime_memory_dask_no_workers(spec, executor):
-    pytest.importorskip("dask.distributed")
     if executor.name != "dask":
         pytest.skip(f"{executor.name} executor does not support check_runtime_memory")
 

pyproject.toml

@@ -110,3 +110,8 @@ test-modal = [
 homepage = "https://github.com/cubed-dev/cubed"
 documentation = "https://tomwhite.github.io/cubed"
 repository = "https://github.com/cubed-dev/cubed"
+
+[tool.pytest.ini_options]
+filterwarnings = [
+    "error::UserWarning",
+]