Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a single set of example scripts that can run on any executor #395

Merged
merged 1 commit into from
Feb 27, 2024

Conversation

tomwhite
Copy link
Member

This is not ready for merging, but shows how the examples can be simplified so they can run on any executor.

From the examples directory, run as follows:

export LITHOPS_CONFIG_FILE=~/.lithops/config.aws
CUBED_CONFIG=$(pwd)/lithops/aws-lambda python add-random.py

@tomwhite tomwhite linked an issue Feb 22, 2024 that may be closed by this pull request
@TomNicholas
Copy link
Collaborator

Cool!

@tomwhite
Copy link
Member Author

A similar approach should work for benchmarking too.

@tomwhite tomwhite marked this pull request as ready for review February 26, 2024 16:46
@tomwhite
Copy link
Member Author

I've updated and tested Lithops, Modal, and Coiled with the new changes. (I've left Beam unchanged as it uses a command line parser for its arguments.)

This is not ready to be merged yet, as it relies on changes that have not been released. I'd like to merge #396, #397, and #398 and then do a release in a day or so. @TomNicholas please let me know if there's anything else you'd like in the release.

@TomNicholas
Copy link
Collaborator

Looks great! No requests.

@tomwhite tomwhite merged commit 2f28b49 into main Feb 27, 2024
5 of 6 checks passed
@tomwhite tomwhite deleted the examples-config branch February 27, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate executor configuration from computation
2 participants