-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature]: Supports write disable option #2537
Conversation
@leonrayang Please take a look. |
Codecov Report
@@ Coverage Diff @@
## master #2537 +/- ##
=========================================
Coverage ? 41.36%
=========================================
Files ? 553
Lines ? 113608
Branches ? 0
=========================================
Hits ? 46998
Misses ? 62615
Partials ? 3995
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2afb4bb
to
5ca933c
Compare
2c6ee3f
to
f931359
Compare
@NaturalSelect you can take a referenc for mp's follower read
|
Yes, that's what I'm doing now. |
56eb31e
to
e202556
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once volume is forbidden, all data partition & meta partition in this volume should also set to be status rdonly in master
0dbf4b5
to
324d1e6
Compare
0ec0e07
to
a590fdc
Compare
a590fdc
to
4f4077f
Compare
✅ Deploy Preview for cubefs-check ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
4f4077f
to
8cb67b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
8cb67b6
to
e5915fb
Compare
Signed-off-by: NaturalSelect <2145973003@qq.com>
e5915fb
to
0b086b6
Compare
Signed-off-by: NaturalSelect <2145973003@qq.com>
Signed-off-by: NaturalSelect <2145973003@qq.com>
Signed-off-by: NaturalSelect <2145973003@qq.com>
What this PR does / why we need it:
NOTE: master will put partition status to node, only when their status inconsistent with master, this check process will be completed by heartbeat.
Forbid a volume:
Unforbid a volume:
NOTE: When I unforbid the partition, execute
echo "2" >> a.txt
still get a I/O error, but it will success when I executeecho "1" >> b.txt
, I don't know what cause the problem, please let me know if you have any idea about it.Which issue this PR fixes:
fixes #2477
Special notes for your reviewer:
Please contract me, if the pull request passed the review.
Maybe update client to check "forbidden partition error" is necessarily.
Release note: