fix(master): if init data partitions failed when create volume, mark volume status as delete to trigger background deletion. #2653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…volume status as delete to trigger background deletion. close: cubefs#2019 Signed-off-by: true1064 <tangjingyu@oppo.com>
✅ Deploy Preview for cubefs-check ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## master #2653 +/- ##
==========================================
+ Coverage 41.96% 41.97% +0.01%
==========================================
Files 566 566
Lines 115786 115861 +75
==========================================
+ Hits 48584 48636 +52
- Misses 63020 63045 +25
+ Partials 4182 4180 -2
... and 16 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
currently, if initDataPartitions() failed in the creating vol procedure, the vol info is not cleaned, so it can be found in the master but can't be used.
should clean the vol info if initDataPartitions() failed when creating.
Which issue this PR fixes:
fixes #2019